[4.2] disable test_currencyPluralMinimumIntegerDigits #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_currencyPluralMinimumIntegerDigits does not and did never work on Ubuntu 14.04. In Swift 5 it works because a newer ICU is vendored which fixes the issue. But in Swift 4.2.x we don't vendor ICU so we can't get this test to work on Ubuntu 14.04, hence removing as it's no worse than Swift 4.2.3.
weissi
changed the title
|
@swift-ci please test 4.2 |
|
Is there any way to make this conditional on the Ubuntu flavor in use? Maybe use ICU version as a proxy? It seems like we're likely to restore this regression without this test. |
Linux flavours and versions are not covered by the |
|
@swift-ci please test linux |
|
@kevints Pre 5.0 a lot of tests were simply commented out because they failed on 14.04. Unfortunately the CI doesn't include 14.04 so these sort of failures are not picked up pre-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_currencyPluralMinimumIntegerDigits does not and did never work on
Ubuntu 14.04. In Swift 5 it works because a newer ICU is vendored which
fixes the issue. But in Swift 4.2.x we don't vendor ICU so we can't get
this test to work on Ubuntu 14.04, hence removing as it's no worse than
Swift 4.2.3.