Implement Missing Command Line Quoting on Windows

[gmittert]

No description provided.

[gmittert]

@compnerd

[jakepetroules]

Can you please keep the transformation of the [String] input to the final String passed to the native API, localized to a single function call? Like:

private func quoteWindowsCommandLine(_ commandLine: [String]) -> String {
    func quoteWindowsCommandArg(arg: String) -> String { /* ... */ }
    return commandLine.map(quoteWindowsCommandArg).joined(separator: " ")
}

[jakepetroules]

Please remove the trailing semicolons from within this function

[gmittert]

Oof, that's what I get for copying c++ code without thinking about it.

[jakepetroules]

Thanks!

[compnerd]

@swift-ci please test

[gmittert]

Seems like something else failed?

<unknown>:0: error: module file '/tmp/org.llvm.clang.buildnode/ModuleCache/26WBVC9BAJTXE/_Builtin_stddef_max_align_t-2M3A8EWILE044.pcm' is out of date and needs to be rebuilt: signature mismatch
08:39:23 <unknown>:0: note: imported by module 'CoreFoundation' in '/tmp/org.llvm.clang.buildnode/ModuleCache/26WBVC9BAJTXE/CoreFoundation-2V85TRDDMO0NQ.pcm'
08:39:23 swiftc: /home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/llvm/tools/clang/lib/Serialization/InMemoryModuleCache.cpp:36: llvm::MemoryBuffer &clang::InMemoryModuleCache::addBuiltPCM(llvm::StringRef, std::unique_ptr<llvm::MemoryBuffer>): Assertion `!PCM.IsFinal && "Trying to override finalized PCM?"' failed.
08:39:23 Stack dump:
08:39:23 0.	<eof> parser at end of file

[compnerd]

@swift-ci please test