Refactor if statements in URL.swift #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I refactored some of the if statements in URL.swift to be guard instead. This made the code shorter and easier to read.
|
@swift-ci Please test |
ikesyo
approved these changes
Mar 23, 2019
There was a problem hiding this comment.
Thanks for the contribution! This looks good to me 👍
Can you also submit a pull request on apple/swift for porting this to the Foundation overlay?
https://github.com/apple/swift/blob/master/stdlib/public/Darwin/Foundation/URL.swift
|
@ikesyo Sure! I actually wasn't sure where to send the PR, so thank you very much! |
|
@ikesyo Done! Sorry it took me a while, here's the link to the new PR: swiftlang/swift#23515 |
millenomi
pushed a commit
that referenced
this pull request
Nov 11, 2020
I refactored some of the if statements in URL.swift to be guard instead. This made the code shorter and easier to read. This mirrors my commit on swift-corelibs-foundation (PR #2034)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my first PR so if there's something wrong (name of the branch, commit message, etc) please let me know.
Next time I'll to make something more impactful. 🙇