Skip to content

Implement Host.isEqual and Test #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 29, 2019
Merged

Implement Host.isEqual and Test #2036

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0dd9382
Implement Host.isEqual and Test
khashiguchi Mar 23, 2019
fffb60b
Merge branch 'master' of https://github.com/khashiguchi/swift-corelib…
khashiguchi Mar 23, 2019
0b573bd
Fix Host.isEqual
khashiguchi Mar 23, 2019
71ca3b6
Fix Host.isEqual
khashiguchi Mar 28, 2019
1ea949b
Fix TestHost.test_isEqual
khashiguchi Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Foundation/Host.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ open class Host: NSObject {
}

open func isEqual(to aHost: Host) -> Bool {
return false
return aHost._addresses == _addresses && aHost._info == _info && aHost._names == _names && aHost._resolved == _resolved && aHost._type == _type
}

internal func _resolveCurrent() {
Expand Down
14 changes: 14 additions & 0 deletions TestFoundation/TestHost.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ class TestHost: XCTestCase {
static var allTests: [(String, (TestHost) -> () throws -> Void)] {
return [
("test_addressesDoNotGrow", test_addressesDoNotGrow),
("test_isEqual_positive", test_isEqual_positive),
("test_isEqual_negative", test_isEqual_negative)
]
}

Expand All @@ -32,5 +34,17 @@ class TestHost: XCTestCase {
let swiftAddressesSecond = swift.addresses
XCTAssertEqual(swiftAddressesSecond.count, swiftAddressesFirst.count)
}

func test_isEqual_positive() {
let host0 = Host(address: "8.8.8.8")
let host1 = Host(address: "8.8.8.8")
XCTAssertTrue(host0.isEqual(to: host1))
}

func test_isEqual_negative() {
let host0 = Host(address: "8.8.8.8")
let host1 = Host(address: "8.8.8.9")
XCTAssertFalse(host0.isEqual(to: host1))
}
}