Skip to content

Implement NSSet#description #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2019
Merged

Implement NSSet#description #2037

merged 4 commits into from
Mar 26, 2019

Conversation

rikusouda
Copy link
Contributor

Because NSSet#description was not implemented.

@rikusouda
[Foundation] Implement NSSet#description
0856854 
Because `NSSet#description` was not implemented.
@spevans
Copy link
Contributor

spevans commented Mar 23, 2019

@swift-ci test

spevans
spevans reviewed Mar 23, 2019
View reviewed changes
Foundation/NSSet.swift Outdated
indent += " "
}
var result = indent + "{(\n"
let cnt = count
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is cnt needed here? It seems to just mirror the value held in count?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!
I fixed it. 231c8be

@spevans
Copy link
Contributor

spevans commented Mar 23, 2019

@swift-ci test

1 similar comment
@spevans
Copy link
Contributor

spevans commented Mar 23, 2019

@swift-ci test

@ikesyo
Copy link
Member

ikesyo commented Mar 23, 2019

@swift-ci test Linux platform

@rikusouda
Copy link
Contributor Author

Could you start test? 🙇

@spevans
Copy link
Contributor

spevans commented Mar 23, 2019

@swift-ci test

1 similar comment
@ikesyo
Copy link
Member

ikesyo commented Mar 24, 2019

@swift-ci test

@rikusouda
Copy link
Contributor Author

Fixed it again

@ikesyo
Copy link
Member

ikesyo commented Mar 24, 2019

@swift-ci Please test

1 similar comment
@spevans
Copy link
Contributor

spevans commented Mar 24, 2019

@swift-ci Please test

@spevans
Copy link
Contributor

spevans commented Mar 24, 2019

FYI, the test failures are not related to your changes, they look to be due to issues in one of the other repositories.

@spevans
Copy link
Contributor

spevans commented Mar 24, 2019

@swift-ci test linux

@rikusouda
Copy link
Contributor Author

FYI, the test failures are not related to your changes, they look to be due to issues in one of the other repositories.

Thanks for your information! I got it.

@rikusouda
Copy link
Contributor Author

Is there any action I should to do?

@ikesyo
Copy link
Member

ikesyo commented Mar 26, 2019

@swift-ci Please test Linux platform

@ikesyo ikesyo changed the title [Foundation] Implement NSSet#description Implement NSSet#description Mar 26, 2019
@ikesyo ikesyo merged commit 7e390f3 into swiftlang:master Mar 26, 2019
@ikesyo
Copy link
Member

ikesyo commented Mar 26, 2019

Thanks for working on it!

@rikusouda
Copy link
Contributor Author

Thanks a lot

@rikusouda rikusouda deleted the nsset_description branch March 26, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spevans spevans spevans left review comments

@ikesyo ikesyo ikesyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikusouda @spevans @ikesyo