[5.0] SR-10240: Dont try to write an empty Data() as it has a nil baseAddress. #2054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
karthikkeyan
reviewed
Apr 1, 2019
| @@ -126,7 +126,9 @@ open class FileHandle : NSObject, NSSecureCoding { | |||
| guard _fd >= 0 else { return } | |||
| data.enumerateBytes() { (bytes, range, stop) in | |||
There was a problem hiding this comment.
Just mentioning, looks like the method enumerateBytes() is deprecated in Swift 5.0. I am unsure if this PR is an appropriate place to make the changes, if not, I will update that the code in separate PR.
There was a problem hiding this comment.
I was trying to keep the fix as minimal as possible, I may update to it in a separate PR.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.0 version of #2053. This crashes in 5.0 as the region has
baseAddress = nil