Platform check for TestFoundation failures for Apple Swift 5 Toolchain on PowerPC64LE(SR-10255) #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spevans can someone please review and approve this PR? |
|
@compnerd needed help to review this PR, please suggest who can review this? |
|
CC: @millenomi |
spevans
requested changes
Apr 5, 2019
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Any updates on this one? |
spevans
approved these changes
Apr 10, 2019
|
@spevans I have squashed the commits down to 1 single commit, please go ahead and merge. |
|
@swift-ci test and merge |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file "TestFoundation/TestNSNumber.swift" I could see several sections of code having XCTAssertEqual within conditional checks for architectures and OS. For e.g.:-
#if !(os(Linux) && (arch(arm) || arch(powerpc64) || arch(powerpc64le)))
// Linux/arm and Linux/power chars are unsigned, so Int8 in Swift, until this issue is resolved, these tests will always fail.
XCTAssertEqual(NSNumber(value: Int8(-37)).floatValue, Float(-37))
#endif
I have introduced this PR with similar checks for powerpc64le(followed by SR number in comments) for the 2 test failures reported in this SR. This would help move ahead and make some more progress on powerpc64le, until this issue is resolved by the original contributor of the 2 tests or any other member familiar with the changes.