Parity: Bundle.classNamed(_:) and Bundle.principalClass. #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.classNamed(_:) can now be used, though with a limitation noted in the comments. .principalClass is now implemented in terms of .classNamed(_:)
|
@swift-ci please test |
karthikkeyan
reviewed
Apr 9, 2019
|
|
||
| open var principalClass: AnyClass? { | ||
| // NB: Cross-platform Swift doesn't have a notion of 'the first class in the ObjC segment' that ObjC platforms have. For swift-corelibs-foundation, if a bundle doesn't have a principal class named, the principal class is nil. | ||
| guard let name = infoDictionary?["NSPrincipalClass"] as? String else { return nil } |
There was a problem hiding this comment.
If the principal class is not specified in the information dictionary, the bundle identifies the first class loaded as the principal class. When several classes are linked into a dynamically loadable file, the default principal class is the first one listed on the
ldcommand line.
Reading the documentation looks like the principle-class-not-found case is not handle here.
There was a problem hiding this comment.
That is the case the comment notes, and the comment notes why we don't handle it.
There was a problem hiding this comment.
Thanks for confirming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.classNamed(_:)can now be used, though with a limitation noted in the comments..principalClassis now implemented in terms of.classNamed(_:).Fixes SR-10362.