Skip to content

Complete Freestanding Bundles support in all platforms #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Complete Freestanding Bundles support in all platforms #2093

wants to merge 1 commit into from

Conversation

pvieito
Copy link
Contributor

@pvieito pvieito commented Apr 11, 2019 •
edited
Loading

  • Adds support for finding the bundle path for implicitly loaded bundles (for which we only know the executable path).
  • Unifies Windows and other platforms implementation.
  • Enables Freestanding Bundles tests.

(This simplifies and minimizes the changes proposed at #1570)

@pvieito pvieito changed the title [DRAFT] Completed Freestanding Bundle support in all platforms Completed Freestanding Bundle support in all platforms Apr 13, 2019
@pvieito pvieito marked this pull request as ready for review April 13, 2019 18:29
@pvieito pvieito changed the title Completed Freestanding Bundle support in all platforms Complete Freestanding Bundles support in all platforms Apr 13, 2019
@pvieito
Copy link
Contributor Author

pvieito commented Apr 13, 2019

@compnerd @millenomi

(In a follow-up PR I would merge this commit that includes the SPI commented in #2083)

@spevans
Copy link
Contributor

spevans commented Apr 13, 2019

@swift-ci test

@pvieito
Copy link
Contributor Author

pvieito commented Apr 14, 2019

@spevans Could you restart the tests? Thanks!

@spevans
Copy link
Contributor

spevans commented Apr 14, 2019

@swift-ci test

@pvieito
Copy link
Contributor Author

pvieito commented Apr 15, 2019 •
edited
Loading

@millenomi This is ready for review.

@pvieito
Copy link
Contributor Author

pvieito commented Apr 16, 2019

(Updated with bundle changes for Android from #2120)

@spevans
Copy link
Contributor

spevans commented Apr 17, 2019

@pvieito could you rebase & squash this to eliminate the merge commit, thanks

@pvieito
Completed Freestanding Bundles support in all platforms
6939757 
- Adds support for finding the bundle path for implicitly loaded bundles (for which we only know the executable path).
- Unifies Windows and other platforms implementation.
- Enables Freestanding Bundles tests.
@pvieito
Copy link
Contributor Author

pvieito commented Apr 17, 2019

@spevans Done!

@spevans
Copy link
Contributor

spevans commented Apr 17, 2019

@swift-ci test

@pvieito pvieito mentioned this pull request Apr 17, 2019
Closed
@spevans
Copy link
Contributor

spevans commented Apr 24, 2019

@swift-ci test

@pvieito
Copy link
Contributor Author

pvieito commented Apr 24, 2019

@millenomi can we merge this?

@pvieito
Copy link
Contributor Author

pvieito commented May 1, 2019

@parkera Who can/should review this? Thanks!

@MaxDesiatov
Copy link
Contributor

@pvieito would you like to resolve the conflict so that this could be reviewed? Thanks!

@pvieito
Copy link
Contributor Author

pvieito commented Jun 15, 2019

@MaxDesiatov Unfortunately, I have requested a review in several occasions for this PR with no response from the maintainers, so I am not longer updating it.

@kylebrowning
Copy link

Well that's really unfortunate...

@finagolfin
Copy link
Member

Ping @pvieito, mind rebasing now?

@shahmishal shahmishal closed this Oct 6, 2020
@shahmishal
Copy link
Member

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pvieito @spevans @MaxDesiatov @kylebrowning @finagolfin @shahmishal