Parity: NSCoding: ByteCountFormatter, failWithError(_:) & ObjC API Notes compatibility. #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes compatibility. Implementation of: - ByteCountFormatter’s NSCoding methods; - Tests, adding a macOS fixture; - Fixtures can now support types that do not support secure coding; - Re-enable failWithError(_:) to just log; - NSStringFromClass and NSClassFromString now have a mapping from swift-corelibs-foundation types to ObjC names, meaning that e.g. NSClassFromString(“NSTask”) will return SwiftFoundation.Process.self and NSStringFromClass(SwiftFoundation.Process.self) will return “NSTask”. This is required for unarchiving formatters (since ByteCountFormatter is “NSByteCountFormatter”, Formatter is “NSFormatter” in archives.)
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
This was referenced Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of:
ByteCountFormatter’sNSCodingmethods;Tests, adding a macOS fixture;
Fixtures can now support types that do not support secure coding;
Re-enable
failWithError(_:)to just log;NSStringFromClassandNSClassFromStringnow have a mapping from swift-corelibs-foundation types to ObjC names, meaning that e.g.NSClassFromString("NSTask")will returnSwiftFoundation.Process.selfandNSStringFromClass(SwiftFoundation.Process.self)will return"NSTask". This is required for unarchiving formatters (sinceByteCountFormatteris"NSByteCountFormatter", Formatter is"NSFormatter"in archives.)Fixes https://bugs.swift.org/browse/SR-10455, https://bugs.swift.org/browse/SR-10351, https://bugs.swift.org/browse/SR-10415.