[SR-10428] URLSession.getTasksWithCompletion method implemented

[karthikkeyan]

• New private property hasTriggredResume introduced to track whether the task actually move past the suspendCount in execution
• New internal property isSuspendedAfterResume introduced to find the accurate state reason for .suspend state

Bug Link: https://bugs.swift.org/browse/SR-10428

[millenomi]

cc @ianpartridge

[millenomi]

@swift-ci please test

[pushkarnk]

fatal error: error in backend: IO failure on output stream. Looks like an unrelated CI failure? Kicking off the CI again.

[pushkarnk]

@swift-ci test

[pushkarnk]

Looks like a different failure this time. A compilation error in Dispatch

error: no such module '_SwiftDispatchOverlayShims'

I'm not sure why this is coming up. Let's start the CI for one more time.

[pushkarnk]

@swift-ci test

[spevans]

@pushkarnk Dispatch always seems to have problems building, unfortunately the underlying build errors are hidden in the logs which makes fixing them harder.

[pushkarnk]

@spevans Oh, thanks for that info. I can see other PR builds going through. Do you have some ways to work around this situation? :)

[pushkarnk]

Looks good to me! We only need to fix the build issues now.

[karthikkeyan]

@pushkarnk Is there anything I had to update in the PR to get the build working?

[spevans]

@swift-ci test

[karthikkeyan]

In my last CI build successfully ran in Linux but failed in macOS X. In my local machine, the project is building successfully with Swift Developer Snapshot 2019-04-04(a). I guess the reason for the build failure has something to do with the CI setup. Anyway, I rebased my branch to have all the latest code. Please trigger the CI build one more time.

@spevans @pushkarnk

[pushkarnk]

@swift-ci test

[pushkarnk]

@karthikkeyan I don't think it has anything to do with the PR. Seems like a CI issue.

[pushkarnk]

@swift-ci test

[pushkarnk]

A different problem this time:

/Users/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-master/swiftpm/Sources/SPMLLBuild/llbuild.swift:13:19: error: compiled module was created by an older version of the compiler; rebuild 'llbuildSwift' and try again: /Users/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-master/Ninja-ReleaseAssert/llbuild-macosx-x86_64/products/llbuildSwift/llbuildSwift.swiftmodule

[pushkarnk]

@shahmishal We're seeing the CI fail with different kinds of issues here (see comments above). Can you please help us out?

[shahmishal]

@swift-ci clean test

[shahmishal]

@swift-ci clean test

[pushkarnk]

@swift-ci clean test

[shahmishal]

@swift-ci clean test

[shahmishal]

@swift-ci test

[shahmishal]

@pushkarnk Sorry, clean is not support. I thought it was.

[spevans]

@swift-ci test macOS

[pushkarnk]

Thanks @shahmishal .. the CI has passed this time!

[pushkarnk]

@karthikkeyan I realised that this pull request also fixes a bug in URLSession.getAllTasks(). We wrongly returned tasks that were in the initial, suspended state (not resumed before being suspended). May I request you to add a test for URLSession.getAllTasks() as well?

[karthikkeyan]

@karthikkeyan I realised that this pull request also fixes a bug in URLSession.getAllTasks(). We wrongly returned tasks that were in the initial, suspended state (not resumed before being suspended). May I request you to add a test for URLSession.getAllTasks() as well?

Of course Pushkar, I will added on more unit test.

[karthikkeyan]

@pushkarnk Thanks for reviewing the PR earlier, I have added unit test for getAllTasks method as well. Please review again when you get a chance.

[spevans]

@swift-ci test

[pushkarnk]

Thanks @karthikkeyan

[pushkarnk]

@swift-ci test and merge

[pushkarnk]

@swift-ci test and merge