Disable toll-free bridging for CFRunLoopTimer #2116
Conversation
| @@ -4306,7 +4306,7 @@ CFIndex CFRunLoopTimerGetOrder(CFRunLoopTimerRef rlt) { | |||
|
|
|||
| void CFRunLoopTimerInvalidate(CFRunLoopTimerRef rlt) { /* DOES CALLOUT */ | |||
| CHECK_FOR_FORK(); | |||
| CF_OBJC_FUNCDISPATCHV(CFRunLoopTimerGetTypeID(), void, (NSTimer *)rlt, invalidate); | |||
| //CF_OBJC_FUNCDISPATCHV(CFRunLoopTimerGetTypeID(), void, (NSTimer *)rlt, invalidate); | |||
There was a problem hiding this comment.
Please do not disable CF_OBJC_… functions. As the name implies, these are for ObjC (and are no-ops in Swift.)
There was a problem hiding this comment.
OK great, I didn't realise that. Specifically that one however does appear to be casting CFRunLoopTimer to NSTimer *, is that ok to keep in?
| @@ -29,7 +29,7 @@ typedef struct CF_BRIDGED_MUTABLE_TYPE(id) __CFRunLoopSource * CFRunLoopSourceRe | |||
|
|
|||
| typedef struct CF_BRIDGED_MUTABLE_TYPE(id) __CFRunLoopObserver * CFRunLoopObserverRef; | |||
|
|
|||
| typedef struct CF_BRIDGED_MUTABLE_TYPE(NSTimer) __CFRunLoopTimer * CFRunLoopTimerRef; | |||
| typedef struct /*CF_BRIDGED_MUTABLE_TYPE(id)*/ __CFRunLoopTimer * CFRunLoopTimerRef; | |||
There was a problem hiding this comment.
Please do not disable this. This does not bridge to NSTimer; it bridges to id, meaning that it allows CFRunLoopTimer to be treated as an AnyObject (and thus its API be imported without using Unmanaged<…>.
There was a problem hiding this comment.
OK makes sense, I did note CFRunLoop itself etc are also CF_BRIDGED_MUTABLE_TYPE there. Should the type remain NSTimer however or be id like the rest?
|
In general, changing public API headers is not allowed. |
|
Noted, thanks. Thanks for the feedback! |
tokyovigilante
force-pushed
the
cfrunlooptimer-unbridged
branch
from
0904581 to
5a5d730
Compare
Foundation.Timer is not currently implemented with a compatible memory layout so attempt to bridge these classes will fail. Disabling bridging allows code using CFRunLoopTimer to work until Foundation.Timer is reimplemented. Fixes https://bugs.swift.org/browse/SR-10465
tokyovigilante
force-pushed
the
cfrunlooptimer-unbridged
branch
from
5a5d730 to
af01e68
Compare
|
This one should do it, works on my system without changing the API. Thanks again for the feedback! |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Foundation.Timer is not currently implemented with a compatible memory layout
so attempt to bridge these classes will fail. Disabling bridging allows
code using CFRunLoopTimer to work until Foundation.Timer is reimplemented.
Fixes https://bugs.swift.org/browse/SR-10465