Skip to content

[5.0] SR-9439: Calendar.dateComponetns: Enable .nanoseconds #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2019
Merged

[5.0] SR-9439: Calendar.dateComponetns: Enable .nanoseconds #2122

merged 1 commit into from
Apr 17, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Apr 16, 2019

(cherry picked from commit d8f09b6)

@spevans
SR-9439: Calendar.dateComponetns: Enable .nanoseconds
7a206e9 
- Nanoseconds were originally disable in swiftlang#1658 to fix SR-7011,
  however the CF/NSCalendar rewrite in swiftlang#1755 fixed them to
  work correctly so they can now be re-enabled.

(cherry picked from commit d8f09b6)
@spevans
Copy link
Contributor Author

spevans commented Apr 16, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Apr 16, 2019 •
edited
Loading

Looks like there is an sscache issue testing the 5.0 branch on macOS:

21:30:41 update-checkout succeeded
21:30:41 Stopping sccache server...
21:30:41 Starting sccache server...
21:30:45 error: unknown setting: cmake-c-launcher
21:30:45 usage: 
21:30:45   build-script [-h | --help] [OPTION ...]
21:30:45   build-script --preset=NAME [SUBSTITUTION ...]

@shahmishal @weissi Do you know a fix?

weissi
weissi approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@weissi
Copy link
Contributor

weissi commented Apr 17, 2019

@swift-ci test

@weissi
Copy link
Contributor

weissi commented Apr 17, 2019

Looks like there is an sscache issue testing the 5.0 branch on macOS:

21:30:41 update-checkout succeeded
21:30:41 Stopping sccache server...
21:30:41 Starting sccache server...
21:30:45 error: unknown setting: cmake-c-launcher
21:30:45 usage: 
21:30:45   build-script [-h | --help] [OPTION ...]
21:30:45   build-script --preset=NAME [SUBSTITUTION ...]

@shahmishal @weissi Do you know a fix?

I don't but I think @shahmishal is working on it.

@shahmishal
Copy link
Member

@swift-ci test macOS

@shahmishal
Copy link
Member

Looks like there is an sscache issue testing the 5.0 branch on macOS:

21:30:41 update-checkout succeeded
21:30:41 Stopping sccache server...
21:30:41 Starting sccache server...
21:30:45 error: unknown setting: cmake-c-launcher
21:30:45 usage: 
21:30:45   build-script [-h | --help] [OPTION ...]
21:30:45   build-script --preset=NAME [SUBSTITUTION ...]

@shahmishal @weissi Do you know a fix?

I don't but I think @shahmishal is working on it.

It should be fixed now.

@weissi
Copy link
Contributor

weissi commented Apr 17, 2019

yay thanks @shahmishal

@weissi weissi merged commit 795a622 into swiftlang:swift-5.0-branch Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spevans @weissi @shahmishal