Skip to content

[5.0] Cherry-pick: Speedup for NSString -getCharacters:range #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

Catfish-Man
Copy link
Contributor

See #1928

@millenomi millenomi changed the title Cherry-pick: Speedup for NSString -getCharacters:range [5.0] Cherry-pick: Speedup for NSString -getCharacters:range Apr 17, 2019
@millenomi
Copy link
Contributor

@swift-ci please test 5.0

@millenomi
Copy link
Contributor

@swift-ci please test

@millenomi
Copy link
Contributor

LGTM.

@Catfish-Man Catfish-Man merged commit 70f41f0 into swift-5.0-branch Apr 17, 2019
@spevans
Copy link
Contributor

spevans commented Apr 19, 2019

@weissi I tested this on Ubuntu18.04 and it seems to cause the swift-5.0-branch to fail some (unrelated) tests.

Where reverting back to before this commit, the tests pass. Most odd.

/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:175: error: TestURLSession.test_dataTaskWithHttpInputStream : Asynchronous wait failed - Exceeded timeout of 12.0 seconds, with unfulfilled expectations: POST http://127.0.0.1:36679/echo: with HTTP Body as InputStream
Test Case 'TestURLSession.test_dataTaskWithHttpInputStream' failed (12.001 seconds)
Test Case 'TestURLSession.test_downloadTaskWithURL' started at 2019-04-19 17:04:29.634
Test Case 'TestURLSession.test_downloadTaskWithURL' passed (8.0 seconds)
Test Case 'TestURLSession.test_downloadTaskWithURLRequest' started at 2019-04-19 17:04:37.634
Test Case 'TestURLSession.test_downloadTaskWithURLRequest' passed (8.0 seconds)
Test Case 'TestURLSession.test_downloadTaskWithRequestAndHandler' started at 2019-04-19 17:04:45.634
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:214: error: TestURLSession.test_downloadTaskWithRequestAndHandler : Asynchronous wait failed - Exceeded timeout of 12.0 seconds, with unfulfilled expectations: Download GET http://127.0.0.1:36679/country.txt: with a completion handler
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:210: error: TestURLSession.test_downloadTaskWithRequestAndHandler : XCTAssertNil failed: "URLError(_nsError: The operation could not be completed)" - error = URLError(_nsError: The operation could not be completed)
Test Case 'TestURLSession.test_downloadTaskWithRequestAndHandler' failed (20.002 seconds)
Test Case 'TestURLSession.test_downloadTaskWithURLAndHandler' started at 2019-04-19 17:05:05.636
Test Case 'TestURLSession.test_downloadTaskWithURLAndHandler' passed (8.001 seconds)
Test Case 'TestURLSession.test_finishTaskAndInvalidate' started at 2019-04-19 17:05:13.637
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:161: error: TestURLSession.test_finishTaskAndInvalidate : XCTAssertNotNil failed - 
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:162: error: TestURLSession.test_finishTaskAndInvalidate : XCTAssertNotNil failed - 
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:163: error: TestURLSession.test_finishTaskAndInvalidate : XCTAssertNil failed: "URLError(_nsError: The operation could not be completed)" - 
/home/spse/swift-source/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:167: error: TestURLSession.test_finishTaskAndInvalidate : failed - response (nil) invalid
Test Case 'TestURLSession.test_finishTaskAndInvalidate' failed (3.998 seconds)

@parkera parkera deleted the unicopy-5.0 branch July 30, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants