[foundation] RelWithDebInfo should build the same as Release. #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Apr 18, 2019
Enable optimizations also for RelWithDebInfo builds.
drodriguez
force-pushed
the
relwithdebinfo-optmized
branch
from
fb8b189 to
ac3d300
Compare
|
Switch the logic as the feedback proposed. I will hold for merging. |
|
Thanks for holding off on the change. I've tracked down the issue, and hope to get that issue dealt with in a day or so. The problem is in LLVM, I've found the issue and have a fix for it. Just committed it upstream and waiting on the bots to run through before I create the PR for it to pull it into stable. |
|
@compnerd Ping me on this PR when it's time to merge. |
|
Okay, at this point, this should not regress the Windows build as the compiler side of the issue has been taken care of. Lets get it through the bots first though. |
|
@swift-ci please test |
|
@millenomi - ping :-) |
|
@compnerd Pong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable optimizations also for RelWithDebInfo builds.