Foundation: add ProcessInfo SPI for tests #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
colemancda
reviewed
Apr 19, 2019
millenomi
suggested changes
Apr 19, 2019
|
@swift-ci please test |
Add the `_processPath` computed property on `ProcessInfo` to allow the tests to access `_CFProcessPath`. This removes the last CoreFoundation API usage in the test suite, allowing it to build on Windows which does not provide the CoreFoundation APIs to users.
|
@millenomi - okay to merge? |
millenomi
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
_processPathcomputed property onProcessInfoto allow thetests to access
_CFProcessPath. This removes the last CoreFoundationAPI usage in the test suite, allowing it to build on Windows which does
not provide the CoreFoundation APIs to users.