Skip to content

[BUILD AND TEST FIX] Mark several tests as XFAIL #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2019
Merged

[BUILD AND TEST FIX] Mark several tests as XFAIL #2142

merged 1 commit into from
Apr 18, 2019

Conversation

millenomi
Copy link
Contributor

  • Add infrastructure to mark a test as XFAIL. You can set the NS_FOUNDATION_ATTEMPT_XFAIL_TESTS environment variable to YES to attempt them.

  • TestFileManager fails to find a creationDate on kernel >= 4.11.0 in Docker. Mark this as XFAIL;

  • test_substringFromCFString is crashing on Ubuntu 14.04. Mark this as XFAIL.

  • test_FromContentsOfURL is failing in CI occasionally. Mark this as XFAIL.

 - Add infrastructure to mark a test as XFAIL. You can set the `NS_FOUNDATION_ATTEMPT_XFAIL_TESTS` environment variable to `YES` to attempt them.

 - TestFileManager fails to find a creationDate on kernel >= 4.11.0 in Docker. Mark this as XFAIL;

 - test_substringFromCFString is crashing on Ubuntu 14.04. Mark this as XFAIL.

 - test_FromContentsOfURL is failing in CI occasionally. Mark this as XFAIL.
@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor Author

millenomi commented Apr 18, 2019

Rules:

  • Mark all uses of the new functions with /* ⚠️ */.
  • Only ever provide a reason that contains a bugs.swift.org URL to the bug tracking the removal of the XFAIL.
  • Ping me immediately if you think you need to use them.

@shahmishal shahmishal merged commit ec5e44e into swiftlang:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants