Fix StringTransform usage of forced casts. #2143
Merged
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… Oh, yep, that makes sense. I have disabled a test that likely tripped on this issue in https://github.com/apple/swift-corelibs-foundation/pull/2142/files — can you revert the |
In Linux, a (constant?) CFString cannot be force casted to String directly. The code generated for those values with optimizations enabled was simply a crash. The changes uses `_swiftObject` to correctly transform to a `Swift.String`. There some other cases in Foundation where other enums are initialized from CF values, but in those cases the literals of the CF values are used, which avoids this problem.
drodriguez
force-pushed
the
fix-string-transform-enum
branch
from
784a248 to
b48e6b9
Compare
|
I re-enabled the test (I didn’t pull from last night, so in my working directory it wasn’t disabled). Should be ready to test. |
|
@swift-ci please test |
|
I think I pushed the new version before the test finished, and CI didn’t start a new test run. |
|
@swift-ci please test |
millenomi
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linux, a (constant?) CFString cannot be force casted to String
directly. The code generated for those values with optimizations enabled
was simply a crash. The changes uses
_swiftObjectto correctlytransform to a
Swift.String.There some other cases in Foundation where other enums are initialized
from CF values, but in those cases the literals of the CF values are
used, which avoids this problem.
Should fix the problems introduced in #2087 in Linux.
PD: I still think that #2087 changes the meaning of the test. It should be reverted or removed.