Foundation: wrap _withStackOrHeapBuffer
#2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
force-pushed
the
inline-inline-inline
branch
from
0ec277a to
44cd237
Compare
|
@swift-ci please test |
`_withStackOrHeapBuffer` is used in multiple functions in Data which are marked as `@inlineable`. Since `_withStackOrHeapBuffer` is inlined into the body, this results in the users getting references to `_CFThreadIsMain` which is SPI in CoreFoundation for Foundation. Furthermore, since the CoreFoundation interfaces are not exported from Foundation, we cannot fulfill the dependency. Create a wrapper over `_withStackOrHeapBuffer` to allow the dependency to be contained.
compnerd
force-pushed
the
inline-inline-inline
branch
from
44cd237 to
51aff9b
Compare
|
@swift-ci please test |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_withStackOrHeapBufferis used in multiple functions in Data which aremarked as
@inlineable. Since_withStackOrHeapBufferis inlined intothe body, this results in the users getting references to
_CFThreadIsMainwhich is SPI in CoreFoundation for Foundation.Furthermore, since the CoreFoundation interfaces are not exported from
Foundation, we cannot fulfill the dependency. Create a wrapper over
_withStackOrHeapBufferto allow the dependency to be contained.