Parity: NSCoding: DateIntervalFormatter #2154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
- Implement NSCoding for DateIntervalFormatter through new hooks in CFDateIntervalFormatter. This requires fixing several bugs uncovered in the process: - Correctly initialize CFDateIntervalFormatter’s date and time style. - Fix __NSSwiftData to never try to encode itself, matching what the Darwin counterpart does. - NSCalendar needs to check if a coder contains values for a specific key before trying to fetch that key. - Add tests with fixtures. Since time zone data can come from different ICU versions, only compare time zone names. - Prevent fixtures with duplicate identifiers.
millenomi
commented
Apr 22, 2019
|
|
||
| /* From https://developer.apple.com/documentation/foundation/nstimezone/1387250-init: | ||
| "Discussion | ||
| As of macOS 10.6, the underlying implementation of this method has been changed to ignore the specified data parameter." |
There was a problem hiding this comment.
cc @compnerd Is this going to be a problem for your implementation?
There was a problem hiding this comment.
Actually for Windows, it is the inverse - that is more inline with the current implementation.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement NSCoding for DateIntervalFormatter through new hooks in CFDateIntervalFormatter. This requires fixing several bugs uncovered in the process:
Correctly initialize CFDateIntervalFormatter’s date and time style.
Fix __NSSwiftData to never try to encode itself, matching what the Darwin counterpart does.
NSCalendar needs to check if a coder contains values for a specific key before trying to fetch that key.
Add tests with fixtures. Since time zone data can come from different ICU versions, only compare time zone names.
Prevent fixtures with duplicate identifiers.