-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[android] Enable Thread tests were possible. #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Enable Thread tests were possible. #2181
Conversation
@swift-ci test |
3246b60
to
2efa9e9
Compare
Removed a preprocessor flag that shouldn’t have been there. @swift-ci please test |
@swift-ci test |
@millenomi: I think I have seen |
@swift-ci please test linux platform |
There is an issue in libdispatch that is being tracked, but the wait kinda needs to match Darwin's. |
Would an |
Is the libdispatch issue in a public tracker that I can follow? I don’t know what you refer with “match Darwin's”, but my proposal is changing the timeout for every platform. If I read the code correctly, this is writing and reading from a pipe, so the delays from reading/writing should be minimal, whatever the platform. I think the change will give us the same signal as we have now, but clearer (it will be the assert about the timeout), instead of a CI build killed because of such timeout. In any case, whatever you think is best. |
@swift-ci please test linux platform |
2efa9e9
to
e84d955
Compare
Rebased and applied the changes from @swift-ci please test |
@swift-ci please test |
e84d955
to
682e069
Compare
Rebased to fix the conflicts in the test file. @swift-ci please test |
682e069
to
830d552
Compare
Rebasing to a recent master. Still passing tests in Linux and Android. @spevans, @millenomi, @compnerd: some feedback? positive or negative? I'm trying to clean up my old “stuck” PRs. @swift-ci please test Linux platform |
Enable most of the Thread test for Android. The only tests that cannot pass right now are the ones related to backtraces, which do not use the Linux API backtrace and would need an specific implementation. And while Android did not get pthread_getname_np until API 26, the low level prctl(PR_GET_NAME) works with the same restriction as in Linux (only 15 characters). With that change, the test about thread names also passes in Android.
830d552
to
138e586
Compare
@swift-ci please test Linux platform |
LGTM |
Enable most of the Thread test for Android. The only tests that cannot
pass right now are the ones related to backtraces, which do not use the
Linux API backtrace and would need an specific implementation.
And while Android did not get pthread_getname_np until API 26, the low
level prctl(PR_GET_NAME) works with the same restriction as in Linux
(only 15 characters). With that change, the test about thread names also
passes in Android.