Foundation: make FileManager build on Windows again #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
gmittert
reviewed
May 1, 2019
compnerd
force-pushed
the
time-to-get-a-watch
branch
2 times, most recently
from
537cc10 to
b7bcb4f
Compare
|
@swift-ci please test |
|
@swift-ci please test and merge |
compnerd
force-pushed
the
time-to-get-a-watch
branch
from
b7bcb4f to
042feec
Compare
|
@swift-ci please test and merge |
compnerd
force-pushed
the
time-to-get-a-watch
branch
from
042feec to
2eac6f1
Compare
|
@swift-ci please test and merge |
Windows should use `SetFileTime` for adjusting the file times. More importantly, it does not support `time_t` so the signature of the POSIX functions are different. Factor out the file time adjustment into a helper that is implemented in the POSIX/Win32 layer and use that instead.
compnerd
force-pushed
the
time-to-get-a-watch
branch
from
2eac6f1 to
10bc20b
Compare
|
@swift-ci please test and merge |
|
@swift-ci please test Linux platform |
4 similar comments
|
@swift-ci please test Linux platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows should use
SetFileTimefor adjusting the file times. Moreimportantly, it does not support
time_tso the signature of the POSIXfunctions are different. Factor out the file time adjustment into a
helper that is implemented in the POSIX/Win32 layer and use that
instead.