SR-10619: Order in which DateFormatter settings are set up matters on Linux #2219
+63
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Linux - Ensure the setting of .dateStyle and .timeStyle isnt dependant on the current setting of .locale.
|
@swift-ci test |
|
cc @weissi |
millenomi
reviewed
May 6, 2019
| ] | ||
|
|
||
| // Test all of the combinations of setting the properties produces the same output | ||
| let expected = "5. mai 2019, 12:52:10" |
There was a problem hiding this comment.
Can this be like other tests in that we do not hardcode an answer, so we avoid ICU changes from causing breakage?
There was a problem hiding this comment.
I tested this against Darwin Foundation and it worked find so I don't think this string is ICU version dependant. The PR actually fixes all of the current tests that are disabled due to not working correctly versus Darwin and will be enabled in a followup PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current setting of .locale.