CoreFoundation: correct CreateStringFromFileSystemRepresentationByAdd… #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @millenomi |
|
@swift-ci please test |
millenomi
reviewed
May 9, 2019
…ingPercentEscapes On Windows, `CreateStringFromFileSystemRepresentationByAddingPercentEscapes` would only partially convert the slash character to %2F. This would result in paths being truncated. Fix this behaviour to canonicalise the separator properly always. Unfortunately, this uncovered some new cases of file path handling being broken on Windows. Add tests to record those cases so that we can fix them subsequently.
compnerd
force-pushed
the
separation-is-never-easy
branch
from
d5a4147 to
365fe8b
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ingPercentEscapes
On Windows,
CreateStringFromFileSystemRepresentationByAddingPercentEscapeswouldonly partially convert the slash character to %2F. This would result in
paths being truncated. Fix this behaviour to canonicalise the separator
properly always. Unfortunately, this uncovered some new cases of file
path handling being broken on Windows. Add tests to record those cases
so that we can fix them subsequently.