Parity: NSCoding: NSCharacterSet #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split initialization for CFCharacterSet so we can use it in init?(coder:) - Make CFCharacterSetPriv.h available to Swift so we can use its helpers to encode and decode as we do on Darwin.
|
@swift-ci please test |
|
This may require a CMakeLists.txt change to make the header visible — let's see if it compiles. |
millenomi
commented
May 8, 2019
| @@ -383,4 +356,48 @@ class TestCharacterSet : XCTestCase { | |||
| // complete. | |||
| allowIncompleteHashing: true) | |||
| } | |||
|
|
|||
| let fixtures = [ | |||
| // Fixtures.characterSetEmpty, | |||
There was a problem hiding this comment.
This isn't right, whoops.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split initialization for CFCharacterSet so we can use it in init?(coder:)
Make CFCharacterSetPriv.h available to Swift so we can use its helpers to encode and decode as we do on Darwin.