build: port to new Swift support #2304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports the foundation build to use the new builtin Swift support in CMake. It allows for a significant cleanup of the build rules.
millenomi
reviewed
Jul 23, 2019
| @@ -422,6 +426,9 @@ if(NOT CMAKE_SYSTEM_NAME STREQUAL Darwin) | |||
| PRIVATE | |||
| ${LIBXML2_INCLUDE_DIR}) | |||
| find_package(CURL REQUIRED) | |||
| target_include_directories(CoreFoundation | |||
There was a problem hiding this comment.
CoreFoundation is not supposed to import or link with libcurl.
There was a problem hiding this comment.
Yeah, this is based on an older state of the tree. I will have to redo the work, this was to demonstrate what the build would look like.
|
Superseded by #2524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the foundation build to use the new builtin Swift support in
CMake. It allows for a significant cleanup of the build rules.