Skip to content

Added missing cmake dependency on FoundationNetworking #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

gmittert
Copy link
Contributor

@gmittert gmittert commented Jun 5, 2019

xdgTestHelper was building before FoundationNetworking finished and wasn't finding the import.

@gmittert
Copy link
Contributor Author

gmittert commented Jun 5, 2019

@swift-ci please test

2 similar comments
@gmittert
Copy link
Contributor Author

gmittert commented Jun 5, 2019

@swift-ci please test

@millenomi
Copy link
Contributor

@swift-ci please test

@gmittert
Copy link
Contributor Author

gmittert commented Jun 7, 2019

@swift-ci please test macos platform

@millenomi
Copy link
Contributor

macOS is temporarily broken and @shahmishal has been informed — it's out of our hands.

@millenomi millenomi merged commit dc37fc7 into swiftlang:master Jun 7, 2019
@gmittert gmittert deleted the MissingHop branch June 7, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants