Skip to content

Fix Flags in NS_open #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2019
Merged

Fix Flags in NS_open #2326

merged 1 commit into from
Jun 11, 2019

Conversation

gmittert
Copy link
Contributor

@gmittert gmittert commented Jun 11, 2019 •
edited
Loading

  • Handle the O_CREATE | O_TRUNC case
  • Read only should be set if write permissions are not set

@gmittert
Fix Flags in NS_open
442a91e 
- Handle the O_CREATE | O_TRUNC case
- Read only should be set it _write_ permissions are not set
@gmittert
Copy link
Contributor Author

@swift-ci please test

@millenomi millenomi merged commit a702cf3 into swiftlang:master Jun 11, 2019
@gmittert gmittert deleted the ComeInWereOpen branch June 11, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmittert @millenomi