Skip to content

Fix up _contentsOfDir on Windows #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2019
Merged

Fix up _contentsOfDir on Windows #2328

merged 1 commit into from
Jun 12, 2019

Conversation

gmittert
Copy link
Contributor

  • FindFirstFileW should be given a directory with \* else it will only
    return the given directory
  • . and .. should be excluded from the results

@gmittert
Fix up _contentsOfDir on Windows
0ea7ab3 
- FindFirstFileW should be given a directory with \\* else it will only
return the given directory
- . and .. should be excluded from the results
@millenomi
Copy link
Contributor

@swift-ci please test linux

@millenomi
Copy link
Contributor

cc @compnerd?

@compnerd compnerd merged commit 6b80b41 into swiftlang:master Jun 12, 2019
@gmittert gmittert deleted the PeeringInside branch June 26, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmittert @millenomi @compnerd