-
Notifications
You must be signed in to change notification settings - Fork 1.2k
HTTPCookie: parse domain according to RFC #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPCookie: parse domain according to RFC #2373
Conversation
@swift-ci please test |
1 similar comment
@swift-ci please test |
@swift-ci please test |
@drodriguez This patch needs conflict resolution before merging. |
When the domain field is specified, the cookie is intended for the domain and subdomains, so the value of domain has to be prefixed by a dot. Added tests to check for this behaviour and modified the incorrect tests.
29f9550
to
84d0b3a
Compare
Conflicts resolved. @swift-ci please test Linux platform |
@swift-ci test linux |
@swift-ci please test Linux platform |
This broke the Windows build :-(. https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=4605&view=logs&j=b9e62f99-1a98-5ed7-01d2-f4794231ed79
|
I saw that yesterday. I was trying to rebuild everything in Windows to try to fix it. It might be a missing import of WinSDK, or a slightly different functiin name. I will try to finish that today. |
When the domain field is specified, the cookie is intended for the
domain and subdomains, so the value of domain has to be prefixed by a
dot.
Added tests to check for this behaviour and modified the incorrect
tests.
NOTE: I checked this behaviour in macOS 13.14.5, and it matches Foundation there.