Use NSDecimalString(_:_) for Decimal -> String conversion. #2396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test linux |
millenomi
reviewed
Jul 8, 2019
Foundation/Decimal.swift
Outdated
| var decimalSeparator: String? | ||
| if let locale = locale as? Locale { | ||
| decimalSeparator = locale.decimalSeparator | ||
| } else if let dictionary = locale as? Dictionary<NSLocale.Key, String> { |
There was a problem hiding this comment.
Should this be [NSLocale.Key: Any]?
Note that unlike Darwin, NSLocale.Key will not automatically bridge from String or NSString. Should we have a branch for that too?
There was a problem hiding this comment.
I added a branch for [String: String].
For the [NSLocale.Key: Any] case wouldn't that then mean as! casting the value to String? It that what you want it changed to?
There was a problem hiding this comment.
No, the current patch is good as-is.
There was a problem hiding this comment.
(After adding the branch.)
millenomi
reviewed
Jul 8, 2019
- This allows using an optional Locale to localise the output. - Update Decimal.description, NSDecimalNumber.description and NSDecimalNumber.description(withLocale) to call NSDecimalString().
spevans
force-pushed
the
pr_nsdecimal_string
branch
from
2bd89a9 to
4e41c33
Compare
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using an optional Locale to localise the output.
Update Decimal.description, NSDecimalNumber.description and
NSDecimalNumber.description(withLocale) to call NSDecimalString().