[cmake] Use custom command for copying files #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake `file(COPY` will only copy files during the initial configuration, so changes in the headers of CF will not be propagated to the build directory and will make for confussing compilation errors. Using custom commands should keep the dependencies between files correctly updated and Ninja should copy the modified headers during each build if necessary.
compnerd
reviewed
Jul 9, 2019
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake
file(COPYwill only copy files during the initialconfiguration, so changes in the headers of CF will not be propagated to
the build directory and will make for confussing compilation errors.
Using custom commands should keep the dependencies between files
correctly updated and Ninja should copy the modified headers during each
build if necessary.
@compnerd: There might be something about
file(COPYthat I was misunderstanding, but I found that the headers weren't updated with my changes, and I needed to do this change for #2397 to work.