[Windows] Fix TestURL.swift crash #2413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
|
is a valid character in a URL (as a replacement to:
,e.g.
/C|/Users/gwenm
. This causes a test testinghttp://test.com/unescaped|pipe
which is expected to not parse toparse successfully on Windows. The test then tries to parse the
<null url>
in the expected result and crashes.This changes the test to check to make sure it can parse the expected
result instead of force casting so that the test fails instead of
crashing.
This allows TestURL to run to completion in the mean time while working
on URL for Windows.