Implement setAttributesOfItemAtPath for NSFilePosixPermissions attribute #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -137,6 +138,26 @@ class TestNSFileManger : XCTestCase { | |||
| } | |||
| } | |||
|
|
|||
| func test_setFileAttributes() { | |||
| let path = "/tmp/testfile" | |||
There was a problem hiding this comment.
we might not want to use this since it would potentially conflict with other tests running on CI
There was a problem hiding this comment.
I stole this from the get test that was already there.
Can you recommend another design, and I can fix both of them?
There was a problem hiding this comment.
using some sort of unique identifier per-run would be nice to have as a common accessor pattern. perhaps /tmp/<some name identifying the test><uuid> might be good as a pattern
|
@swift-ci Please test |
phausler
added a commit
that referenced
this pull request
Mar 1, 2016
Implement setAttributesOfItemAtPath for NSFilePosixPermissions attribute
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Disable diagnostics for blacklisted document schemes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage