Use GetThreadId instead of Storing Handles Directly #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreFoundation keeps a Dictionary of threads to their runloops. On Windows, it previously used the threads' Handle as keys into the dictionary. However, this doesn't work, as if you are attempting to look up or set the current thread's RunLoop using GetCurrentThread. GetCurrentThread returns a psuedo handle (FFFFFFFE) rather than a real handle to a thread which causes it to index incorrectly into the dictionary. This was causing the creation of multiple runloops per thread and then causing dispatch queues not to be pumped leaving blocks to never be run. The fix here is to use the thread id instead of a handle which is unique on the system until the thread terminates.
|
cc @compnerd |
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreFoundation keeps a Dictionary of threads to their runloops. On
Windows, it previously used the threads' Handle as keys into the
dictionary. However, this doesn't work, as if you are attempting to look
up or set the current thread's RunLoop using GetCurrentThread.
GetCurrentThread returns a psuedo handle (FFFFFFFE) rather than a real
handle to a thread which causes it to index incorrectly into the
dictionary.
This was causing the creation of multiple runloops per thread and then
causing dispatch queues not to be pumped leaving blocks to never be run.
The fix here is to use the thread id instead of a handle which is unique
on the system until the thread terminates.