Skip to content

Handle Windows Errors in FileHandle Tests #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

Handle Windows Errors in FileHandle Tests #2441

merged 1 commit into from
Jul 31, 2019

Conversation

gmittert
Copy link
Contributor

  • Errors on Windows are in the WindowsError domain
  • When a file handle for a directory is attemptted to be read, instead
    of ERROR_ACCESS_DENIED as triggered by windows, intercept it and
    return ERROR_DIRECTORY_NOT_SUPPORTED to emulate POSIX's EISDIR
    instead.

@gmittert
Handle Windows Errors in FileHandle Tests
1e4bcd0 
- Errors on Windows are in the WindowsError domain
- When a file handle for a directory is attemptted to be read, instead
of `ERROR_ACCESS_DENIED` as triggered by windows, intercept it and
return `ERROR_DIRECTORY_NOT_SUPPORTED` to emulate POSIX's `EISDIR`
instead.
@gmittert gmittert requested a review from millenomi July 30, 2019 21:34
@gmittert
Copy link
Contributor Author

@swift-ci please test linux

@millenomi millenomi merged commit d1e05c6 into swiftlang:master Jul 31, 2019
@gmittert gmittert deleted the FileHandleIsHandled branch July 31, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millenomi millenomi Awaiting requested review from millenomi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmittert @millenomi