Skip to content

Parity: URLProtocol #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Parity: URLProtocol #2447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Foundation/URLProtocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ open class URLProtocol : NSObject {
@param request A request to make canonical.
@result The canonical form of the given request.
*/
open class func canonicalRequest(for request: URLRequest) -> URLRequest { NSUnimplemented() }
open class func canonicalRequest(for request: URLRequest) -> URLRequest {
NSRequiresConcreteImplementation()
}

/*!
@method requestIsCacheEquivalent:toRequest:
Expand All @@ -272,7 +274,9 @@ open class URLProtocol : NSObject {
implementation-specific checks.
@result YES if the two requests are cache-equivalent, NO otherwise.
*/
open class func requestIsCacheEquivalent(_ a: URLRequest, to b: URLRequest) -> Bool { NSUnimplemented() }
open class func requestIsCacheEquivalent(_ a: URLRequest, to b: URLRequest) -> Bool {
NSRequiresConcreteImplementation()
}

/*!
@method startLoading
Expand Down