Skip to content

Fix key's typo to NSFileGroupOwnerAccountName #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

RyanBreaker
Copy link
Contributor

The key NSFileGroupOwnerAccountId is a typo as it is later overwritten by an NSNumber on line 381. The correct constant is NSFileGroupOwnerAccountName to correctly add the String of the account's name to the dictionary.

The key NSFileGroupOwnerAccountId is a typo as it is later overwritten by an NSNumber on line 381. The correct constant is NSFileGroupOwnerAccountName to correctly add the String of the account's name to the dictionary.
parkera added a commit that referenced this pull request Feb 1, 2016
Fix key's typo to NSFileGroupOwnerAccountName
@parkera parkera merged commit 386f128 into swiftlang:master Feb 1, 2016
@parkera
Copy link
Contributor

parkera commented Feb 1, 2016

Thanks!

@parkera
Copy link
Contributor

parkera commented Feb 1, 2016

Swift CI detected a failure here, which doesn't look related to this change but I've rolled back just in case while we investigate.

@RyanBreaker
Copy link
Contributor Author

The failure is with NSNotificationQueue, which admittedly sparks my own curiosity:

`["TestFoundation/TestNSNotificationQueue.swift:127: error: TestNSNotificationQueue.test_notificationQueueLifecycle : XCTAssertNil failed: "" - "]

["Test Case 'TestNSNotificationQueue.test_notificationQueueLifecycle' failed (0.0 seconds)."]
["Executed 6 tests, with 1 failure (0 unexpected) in 0.011 (0.012) seconds"`

Edit: looking at it myself, I have no idea how my change affects NSNotificationQueue, as there is not even a reference to NSFileManager in NSNotificationQueue's source.

@RyanBreaker RyanBreaker deleted the patch-1 branch February 1, 2016 22:13
@parkera
Copy link
Contributor

parkera commented Feb 1, 2016

@phausler thinks this may be a race condition in the test and not related to your change (which I believe).

@RyanBreaker
Copy link
Contributor Author

Oh interesting, would this potentially be considered a bug then? I'm just curious as to what that means exactly.

@phausler
Copy link
Contributor

phausler commented Feb 2, 2016

The bug is likely to either be exposed by NSThread or it is a bug in CFRunLoop: the thread issue has occurred before but I had thought I fixed it and the run loop backing is quite new and may have a corner case that is not addressed correctly yet. If it is NSThread there is a potential that the mistake is a incorrect usage or failure of withUnsafeMutablePointer. So I doubt this change had anything to do with it besides timing and/or a nondeterministic failure.

@RyanBreaker
Copy link
Contributor Author

I understand it's likely irrelevant to my change, I just can't help but be curious as to what that all means. :)

@RyanBreaker
Copy link
Contributor Author

Is it probably worth trying this pull again?

@parkera
Copy link
Contributor

parkera commented Mar 21, 2016

@swift-ci please test

@parkera
Copy link
Contributor

parkera commented Mar 21, 2016

Yah let's give it a shot.

atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
[test] Disable testMuliEditFixitCodeActionNote
kateinoigakukun pushed a commit to kateinoigakukun/swift-corelibs-foundation that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants