-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix key's typo to NSFileGroupOwnerAccountName #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The key NSFileGroupOwnerAccountId is a typo as it is later overwritten by an NSNumber on line 381. The correct constant is NSFileGroupOwnerAccountName to correctly add the String of the account's name to the dictionary.
Fix key's typo to NSFileGroupOwnerAccountName
Thanks! |
Swift CI detected a failure here, which doesn't look related to this change but I've rolled back just in case while we investigate. |
The failure is with NSNotificationQueue, which admittedly sparks my own curiosity: `["TestFoundation/TestNSNotificationQueue.swift:127: error: TestNSNotificationQueue.test_notificationQueueLifecycle : XCTAssertNil failed: "" - "] ["Test Case 'TestNSNotificationQueue.test_notificationQueueLifecycle' failed (0.0 seconds)."] Edit: looking at it myself, I have no idea how my change affects NSNotificationQueue, as there is not even a reference to NSFileManager in NSNotificationQueue's source. |
@phausler thinks this may be a race condition in the test and not related to your change (which I believe). |
Oh interesting, would this potentially be considered a bug then? I'm just curious as to what that means exactly. |
The bug is likely to either be exposed by NSThread or it is a bug in CFRunLoop: the thread issue has occurred before but I had thought I fixed it and the run loop backing is quite new and may have a corner case that is not addressed correctly yet. If it is NSThread there is a potential that the mistake is a incorrect usage or failure of withUnsafeMutablePointer. So I doubt this change had anything to do with it besides timing and/or a nondeterministic failure. |
I understand it's likely irrelevant to my change, I just can't help but be curious as to what that all means. :) |
Is it probably worth trying this pull again? |
@swift-ci please test |
Yah let's give it a shot. |
[test] Disable testMuliEditFixitCodeActionNote
[pull] swiftwasm from main
The key NSFileGroupOwnerAccountId is a typo as it is later overwritten by an NSNumber on line 381. The correct constant is NSFileGroupOwnerAccountName to correctly add the String of the account's name to the dictionary.