Consistently add #error when compiling on unsupported architectures. #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #if arch() guard blocks are used for per architecture code paths, so for unsupported architectures add an #else/#error message to ensure the correct path is added. - This fixes some initializers that may have otherwise been empty. - Ignore blocks with just one architecture as this is usually a specific targeted fix.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#if arch() guard blocks are used for per architecture code paths, so
for unsupported architectures add an #else/#error message to ensure
the correct path is added.
This fixes some initializers that may have otherwise been empty.
Ignore blocks with just one architecture as this is usually a specific
targeted fix.
I think the message is correct for all cases but can be changed if necessary.