Skip to content

Port: Windows fixes #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2019
Merged

Port: Windows fixes #2472

merged 1 commit into from
Aug 16, 2019

Conversation

millenomi
Copy link
Contributor

  • WinSock doesn’t define the sa_* and in_* types.
  • in_addr is a union on Windows instead of a scalar. Remove the reliance on that and copy the bytes over instead.
  • IPPROTO_TCP is imported typed. Shim it as a scalar.

@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Port: Windows fixes
3c244f7 
 - WinSock doesn’t define the sa_* and in_* types.
 - in_addr is a union on Windows instead of a scalar. Remove the reliance on that and copy the bytes over instead.
 - IPPROTO_TCP is imported typed. Shim it as a scalar.
 - Native socket handles are not the same size as SocketNativeHandle; cast explicitly between the two.
@millenomi
Copy link
Contributor Author

@swift-ci please test

2 similar comments
@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi
Copy link
Contributor Author

@swift-ci please test

@millenomi millenomi merged commit 2e4734c into swiftlang:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@millenomi