Addressing 32-bit issues with NSXMLNodeOptions #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,55 +43,55 @@ | |||
| @constant NSXMLDocumentIncludeContentTypeDeclaration Include a content type declaration for HTML or XHTML | |||
| */ | |||
|
|
|||
| #if arch(x86_64) || arch(arm64) | |||
| public typealias NSXMLNodeOptionRawType = Int | |||
| #if arch(x86_64) || arch(arm64) || arch(powerpc64le) | |||
There was a problem hiding this comment.
so we have to keep bumping this when we get other 64 bit platforms? mips etc? is there not a swift defined or 64 bit?
There was a problem hiding this comment.
Yes, I believe so. There are no configuration statements listed for bit-width in the Swift Programming Language book. I would love for that to exist.
|
I dont know what happened to your comment, but yes. The bitmask seems to have worked as expected on 32 & 64 bit machines. That's much better! |
|
👍 I like this change, builds cleanly and tests pass |
phausler
added a commit
that referenced
this pull request
Feb 4, 2016
Addressing 32-bit issues with NSXMLNodeOptions
|
Thanks the the help, Philippe! 😀 |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Make BuildSystemManager passthrough notifications fully `async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to address the issues with NSXMLNodeOptions on 32-bit platforms in a way that doesn't impact the API. The current problem (that
NSXMLNodeOptionRawTypeaimed to fix) is that the assignment of the sign bit of an Int is flagged by Swift as an overflow. By assigning this bit with the acknowledgement that it is becoming negative quiets the compiler while maintaining the effect.