[Android][Linux] Fixed hang when using RunLoop.main.run with Date()

[Molanda]

When using RunLoop.main.run(mode: .default, before: Date()) on Android, the call would not return.

This function, along with limitDate (which also would hang), calls CFRunLoopRunInMode. According to the documentation, this should return immediately if seconds is 0.

I traced the problem to __CFRunLoopRun where there are a few platform specific cases for draining the message queue. In the TARGET_OS_LINUX case, the polling condition was not being considered.

This PR fixes the parameter to be poll ? 0 : TIMEOUT_INFINITY as is done for the other platforms, which allows polling to work on Android.

[drodriguez]

@swift-ci please test

[phausler]

looks good to me, it could use a test to verify the appropriate behavior

[bendjones]

Yup same here and agreed about the test...

[Molanda]

I'm building for Ubuntu now to test out the test I added. The result will be pass/hang though.

I did notice that two of the other RunLoop tests are commented out, with a reference to SR-399. This appears to be an issue on Darwin, so I don't see it as related to this fix.

[spevans]

@swift-ci test linux

[Molanda]

Is the test status stuck?

Jenkins is claiming that it was a success.

[spevans]

@Molanda Sometimes the status message from Jenkins -> Github gets lost, i'll start the test again

[spevans]

@swift-ci test linux

[Molanda]

Thank you!

[spevans]

@swift-ci test linux

[Molanda]

Has the build job been changed?

Build 3810 completed successfully on 10/27 with all of my changes. The last step was "Creating installable package".

18:41:50 Setting status of dd402ba04bd324c193a8cc607e03a21c964e9980 to SUCCESS with url https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/3810/ and message: 'Build finished. '
18:41:50 Using context: Swift Test Linux Platform
18:41:50 Setting status of dd402ba04bd324c193a8cc607e03a21c964e9980 to SUCCESS with url https://ci.swift.org/job/swift-corelibs-foundation-PR-Linux/3810/ and message: ' '
18:41:50 Using context: Swift Test Linux Platform
18:41:50 Finished: SUCCESS

This step has been replaced in Build 3825 with the following...

• Building indexstoredb
• Running tests for indexstoredb
• Finished tests for indexstoredb
• Building sourcekitlsp
• Running tests for sourcekitlsp
• Finished tests for sourcekitlsp
• Installing sourcekitlsp
• Building benchmarks

And "Installing swiftpm" now fails with the following error:

21:45:03 IOError: [Errno 2] No such file or directory: '/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/buildbot_linux/benchmarks-linux-x86_64/Benchmark_Onone/debug/SwiftBench'

[drodriguez]

The Swift Package Manager – Benchmarks build error was fixed this morning, after Simon launched the tests.

@swift-ci test linux

[Molanda]

Great, thank you!

[Molanda]

What is the next step for this one?

[drodriguez]

Sorry for the delays. I just merged. Congrats!