Changes related to SE-0028 #255
Conversation
|
One thing i'm not sure about is |
|
The changes to the .c and .h files seem very wrong to me, they won't build. |
|
My bad, will fix |
|
@lattner reverter those changes, sorry for that ¯_(ツ)_/¯ |
|
what corresponding commit for the compiler is this attached to? |
|
thanks |
| @@ -1039,8 +1039,8 @@ func checkHasPrefixHasSuffix(lhs: String, _ rhs: String, _ stack: [UInt]) -> Int | |||
| } | |||
|
|
|||
| var failures = 0 | |||
| failures += testFailure(expectHasPrefix, lhs.hasPrefix(rhs), stack + [__LINE__]) | |||
| failures += testFailure(expectHasSuffix, lhs.hasSuffix(rhs), stack + [__LINE__]) | |||
| failures += testFailure(expectHasPrefix, lhs.hasPrefix(rhs), stack + [#line]) | |||
There was a problem hiding this comment.
This doesn't compile for me.
There was a problem hiding this comment.
Seems [#line] doesn't compile but [ #line] does. Intentional as part of SE-0028?
There was a problem hiding this comment.
This includes keeping
__FUNCTION__, and making#linehave the dual behavior of being a directive when it is the first token on a line, but an expression otherwise.
From SE-0028
So if #line is taken as expression it looks like it should work. Or i'm missing something.
There was a problem hiding this comment.
This was fixed in a follow on patch. Just put a space between the [ and # if you don't have a build with the fix yet.
|
@swift-ci Please test |
Replaces old identifiers with new ones