Skip to content

[cmake] Fix dependencies for xdgTestHelp #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

[cmake] Fix dependencies for xdgTestHelp #2572

merged 1 commit into from
Nov 22, 2019

Conversation

gmittert
Copy link
Contributor

xdgTestHelper imports FoundationNetworking and FoundationXML but doesn't
have an explicit dependency on them which can cause a race condition
while building.

@gmittert
[cmake] Fix dependencies for xdgTestHelp
f0ae1fe 
xdgTestHelper imports FoundationNetworking and FoundationXML but doesn't
have an explicit dependency on them which can cause a race condition
while building.
@gmittert
Copy link
Contributor Author

cc @compnerd

@swift-ci please test and merge

@gmittert
Copy link
Contributor Author

@swift-ci please test macOS

@compnerd compnerd merged commit 2195121 into swiftlang:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmittert @compnerd