Skip to content

[Windows] Fix Interpretation of Volume Name Array #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

gmittert
Copy link
Contributor

@gmittert gmittert commented Dec 3, 2019

Taking &wszPathNAmes[...] doesn't properly get the string and leads to
garbled data. Instead, compute the pointer address and pass that.

@gmittert gmittert requested a review from compnerd December 3, 2019 03:14
@gmittert
Copy link
Contributor Author

gmittert commented Dec 3, 2019

@swift-ci please test

@gmittert
Copy link
Contributor Author

gmittert commented Dec 3, 2019

@swift-ci please test macos

Taking &wszPathNames[...] doesn't properly get the string and leads to
garbled data. Instead, compute the pointer address and pass that.
@gmittert gmittert force-pushed the SaveToTheC_____Drive branch from 8e4feed to ddadd5e Compare December 4, 2019 01:31
@gmittert
Copy link
Contributor Author

gmittert commented Dec 4, 2019

@swift-ci please test linux

@gmittert gmittert merged commit 0381c45 into swiftlang:master Dec 6, 2019
@gmittert gmittert deleted the SaveToTheC_____Drive branch December 6, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants