SR-11922: [FileHandle] Make the function signature the same as DarwinFoundation. #2582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test linux |
|
@YOCKOW The old methods still needs to be tested so I would suggest restoring the original |
|
@spevans |
Since `func truncateFile(atOffset offset: UInt64)` has been deprecated, new function is introduced. However, the signatures are different between DarwinFoundation and SwiftFoundation. Resolves https://bugs.swift.org/browse/SR-11922 .
|
Rebased. |
|
@swift-ci test linux |
1 similar comment
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
func truncateFile(atOffset offset: UInt64)has been deprecated, new function is introduced. However, the signatures are different between DarwinFoundation and SwiftFoundation.Resolves SR-11922.