[CF] Fix typo in TARGET_RT_64_BIT ifdef. #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__CFGetFullRetainCount contains an ifdef with symbol name TARGET_RT64_BIT. This is likely a typo since otherwise, __CFDoExternRefOperation is referenced, but is guarded by an ifdef with name TARGET_RT_64_BIT instead, which then manifests as a missing symbol. Other calls to __CFDoExternRefOperation are guarded by the same symbol.
3405691582
force-pushed
the
CFRuntime_Typo
branch
from
bf5d5d7 to
42e78c8
Compare
3405691582
changed the title
|
@swift-ci test |
parkera
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__CFGetFullRetainCount contains an ifdef with symbol name
TARGET_RT64_BIT. This is likely a typo since otherwise,
__CFDoExternRefOperation is referenced, but is guarded by an ifdef with
name TARGET_RT_64_BIT instead, which then manifests as a missing symbol.
Other calls to __CFDoExternRefOperation are guarded by the same symbol.