[CF] Implement strlcpy and strlcat once in Prefix. #2599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strlcpy and strlcat implementations are required for: * LINUX, but not ANDROID nor CYGWIN (since ANDROID and CYGWIN are both LINUX), * WIN32. Instead of implementing strlcpy and strlcat once per TARGET_OS when required, just write the implementation once and modify the conditional. This does mean the ifdef conditional is a little complicated, but overall that is outweighed by the removal of the obvious redundancy and will eventually improve the handling of TARGET_OS_BSD.
|
@swift-ci test |
|
@swift-ci please test Linux platform |
|
Can someone retest for me? I think swift/#29121 might have fixed the Linux bot. |
|
@swift-ci test linux |
compnerd
approved these changes
Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strlcpy and strlcat implementations are required for:
are both LINUX),
Instead of implementing strlcpy and strlcat once per TARGET_OS when
required, just write the implementation once and modify the conditional.
This does mean the ifdef conditional is a little complicated, but
overall that is outweighed by the removal of the obvious redundancy
and will eventually improve the handling of TARGET_OS_BSD.