[CF] Go from three sets of OS* decls to two. #2600
Merged
+19
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Prefix, declarations for the OSAtomic* family of functions and OSMemoryBarrier are duplicated for Linux, BSD, and Windows. In this commit, the declarations for OS* functions are made common, since they are apparently identical for both targets. Unifying the declarations for Windows is a separate task, since those declarations use CF_EXPORT. There might be a nice way to go to just a single set of OS* declarations, but that can come later. This way, this commit is just a structural change rather than a structural and functional one.
3405691582
force-pushed
the
Prefix_CommonOSDecls
branch
from
4653bc6 to
8cc10c8
Compare
compnerd
approved these changes
Jan 9, 2020
|
Thanks for the cleanup! |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Prefix, declarations for the OSAtomic* family of functions and
OSMemoryBarrier are duplicated for Linux, BSD, and Windows. In this
commit, the declarations for OS* functions are made common, since they
are apparently identical for both targets.
Unifying the declarations for Windows is a separate task, since those
declarations use CF_EXPORT. There might be a nice way to go to just a
single set of OS* declarations, but that can come later. This way,
this commit is just a structural change rather than a structural and
functional one.