Fixes for TestNSURL.swift on 32-bit (NFC) #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure this is not a symptom of incorrectly importing some API on Linux/armv7, for example, strlen()? |
|
@gribozavr sorry for the delay in getting back, I was focusing on that other PR. I don't see anywhere where strlen is imported differently from other c functions. Ultimately, size_t is being imported as a UInt32 rather than a UInt. Looking at MappedTypes, it seems like it should be mapped as Int. |
Which is an issue that should be fixed on the compiler side. It will cause a lot of other API inconsistencies. |
phausler
added a commit
that referenced
this pull request
Feb 25, 2016
Fixes for TestNSURL.swift on 32-bit (NFC)
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[test] Workaround an issue with createDirectory on Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively minor patch that casts the result of sizeof to UInt so that UInt32 (from 32-bit machines) is promoted to match the other logic.